gh-114075: Capture test_compileall output #114076
Merged
Merged
Conversation
AlexWaygood
reviewed
Jan 15, 2024
Member
Author
Thanks! Also, there is no need in backports, I cannot reproduce it on 3.11 & 3.12 branches. |
Eclips4
changed the title
StringIO
AlexWaygood
changed the title
test_compileall output
AlexWaygood
reviewed
Jan 15, 2024
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
Member
There was a problem hiding this comment.
The output was added in gh-105931 (PR #108671), when this test was also added.
It can be simply silenced by passing quiet=2. But since there is no other test for this output, it is better to capture the stdout, and then test that an expected message occurred in the captured output. Please add this, not simply ignore it.
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
approved these changes
Jan 15, 2024
AlexWaygood
left a comment
AlexWaygood
left a comment
Member
There was a problem hiding this comment.
LGTM. @serhiy-storchaka, I think @Eclips4's latest push addresses your remark
serhiy-storchaka
approved these changes
Jan 15, 2024
Member
Author
|
Thanks for your reviews! |
kulikjak
pushed a commit
to kulikjak/cpython
that referenced
this pull request
Jan 22, 2024
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_compileallprints uneccessary information #114075